Add logging channel and more logging to chat agent handler #19398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis-sanchez
requested review from
kburtram,
aasimkhan30,
cssuh,
caohai,
laurenastrid1 and
Benjin
as code owners
PR Changes
|
Benjin
approved these changes
May 12, 2025
kburtram
reviewed
May 13, 2025
|
My take on this PR is that we should probably send most the logging to a single channel, perhaps for very specific logging we might want to isolated it, but I don't think we should create a different logging channel for each feature area. Unless VS Code is recommending extensions do that. |
|
Unless I'm misunderstanding, I think we're already doing that; everything's going to the |
kburtram
approved these changes
May 27, 2025
# Conflicts: # src/copilot/chatAgentRequestHandler.ts
Benjin
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #19363