-
Notifications
You must be signed in to change notification settings - Fork 436
OCPBUGS-57458: add MachineConfiguration to CO related objects #5124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-57458: add MachineConfiguration to CO related objects #5124
Conversation
@djoshy: An error was encountered updating to the POST state for bug OCPBUGS-57458 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Post "https://issues.redhat.com/rest/api/2/issue/17062606/transitions": POST https://issues.redhat.com/rest/api/2/issue/17062606/transitions giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@djoshy: This pull request references Jira Issue OCPBUGS-57458, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -64,6 +64,7 @@ func (optr *Operator) syncRelatedObjects(co *configv1.ClusterOperator) { | |||
{Group: "machineconfiguration.openshift.io", Resource: "kubeletconfigs"}, | |||
{Group: "machineconfiguration.openshift.io", Resource: "containerruntimeconfigs"}, | |||
{Group: "machineconfiguration.openshift.io", Resource: "machineconfigs"}, | |||
{Group: "operator.openshift.io", Resource: "machineconfigurations"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e-aws-ovn shows this working:
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Pre-merge verified:
/label qe-approved |
@djoshy: This pull request references Jira Issue OCPBUGS-57458, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/unhold |
verified using IPI on AWS
As we can read in previous comments, the machineconfiguration resource is collected in the gather-extra section of the CI too. /label qe-approved |
1 similar comment
LGTM |
/retest-required |
@djoshy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/override ci/prow/e2e-aws-ovn-upgrade Overriding since this PR has passed the test before on the same commit and failure seems unrelated. |
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-aws-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7177bf1
into
openshift:main
@djoshy: Jira Issue OCPBUGS-57458: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-57458 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.19 release-4.18 release-4.17 |
@djoshy: new pull request created: #5132 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
- What I did
Adds
MachineConfiguration
(where the MCO's global knobs live) to the CO's related objects.- How to verify it
status.relatedObjects
& must gathers should now include theMachineConfiguration
object.