Download fails silently when logged out

[eyaler]

p5.js version

n/a

What is your operating system?

Windows

Web browser and version

firefox 139 / edge 136

Actual Behavior

nothing happens

Expected Behavior

if downloading is not allowed the option should be greyed out or better there should be a modal popup indicating what is the issue

Steps to reproduce

file->download a user's sketch when logged out

[yugalkaushik]

@raclim Can I work on this issue?

[raclim]

@yugalkaushik yes please feel free to go ahead! :)

[yugalkaushik]

@eyaler @raclim I added a tooltip, since a popup can't be linked to the unauthenticated download button because nav buttons are disabled by default when the user isn't logged in.

[raclim]

Thanks for the update @yugalkaushik!

As we discussed in the linked PR, if we want to use a tooltip, we may need to first come up with a way to implement one that's WCAG 2.2 compliant. I'm wondering since the Download button is already disabled when the user isn't logged in, maybe another potential solution could be updating the design to make it's disabled state a bit more evident?

[yugalkaushik]

Yes, that makes sense. We can update the design of the disabled button to make it more visually distinct something like a greyed-out button should help indicate it's inactive.