Skip to content

nonreduce_axis.push to support more dtypes #349

Open
@kefirbandi

Description

@kefirbandi

I found that the nonreduce_axis.push only support dtypes compatible with np.nan, or for which np.isnan is supported.
I'd be happy to attempt to extend the range to other types and submit a PR.
But before I do that would like to know whether such a PR will be considered and what else do I need to know?

I came accross this behavior from xarray.ffill, where I wanted to forward fill string-array, but it failed.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions