-
Notifications
You must be signed in to change notification settings - Fork 294
Rename torchao.float8.Float8Tensor to torchao.float8.Float8TrainingTensor #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jerryzh168/stack/4
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2479
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit b39be5d with merge base 1fd34e4 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
aacfea0
to
5fe4319
Compare
5fe4319
to
f9ba189
Compare
f9ba189
to
782b53f
Compare
782b53f
to
ea9092a
Compare
ea9092a
to
1b8c7cc
Compare
1b8c7cc
to
2a00cd7
Compare
can we test two more things:
./test/float8/test_everything.sh
Also, there are some callsites for |
+1, for torchtitan i would suggest (1) 2d parallel w/ FSDP+TP in torchtitan for all 3 recipes, (2) for tensorwise test enabling fp8 all gather enabled and enabling precompute fp8 weight scales |
2a00cd7
to
4d04b4c
Compare
sg, in this case I can do a forward fix in diff train |
Runs without errors. for torchtitan I have tested:
and
is this enough? |
…nsor Summary: att, since we are introducing a inference version Float8Tensor Test Plan: regression tests for float8 training: pytest test/float8 Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2479, branch: jerryzh168/stack/11
4d04b4c
to
b39be5d
Compare
Stacked PRs:
Rename torchao.float8.Float8Tensor to torchao.float8.Float8TrainingTensor
Summary:
att, since we are introducing a inference version Float8Tensor
Test Plan:
regression tests for float8 training: pytest test/float8
Reviewers:
Subscribers:
Tasks:
Tags: