Skip to content

[ez][HUD] Filter out upload test stats in hud query #6884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jul 3, 2025

This should get filtered out by the workflow_event filters but sometimes the field is empty, maybe because the job is too new? I'm not sure

Each upload test stats job has a different name, based on the job its uploading stats for, so whenever I open the "other" category, which is where these jobs go into, it takes a very long time

@clee2000 clee2000 marked this pull request as ready for review July 3, 2025 16:53
Copy link

vercel bot commented Jul 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jul 3, 2025 4:54pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2025
@clee2000 clee2000 requested a review from a team July 3, 2025 16:53
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I remember this showed up when I loaded HUD before with gazillion of Upload test stats jobs under other. However, they showed up only briefly before being filtered out by something

@clee2000
Copy link
Contributor Author

clee2000 commented Jul 3, 2025

LGTM! I remember this showed up when I loaded HUD before with gazillion of Upload test stats jobs under other. However, they showed up only briefly before being filtered out by something

Yeah, I wonder if the way workflow_event is populated makes it lag a bit? cc @izaitsevfb Or maybe its just that the workflow_job and workflow_run table come from different webhooks so they aren't in sync all the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants