Skip to content

Migrate from Tubes to DBusTube - Tubes are deprecated #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samdroid-apps
Copy link
Contributor

Tested between 2 instances on my fc24 machine, and between fc24 on my laptop and fc20 on my xo4. Worked both times.

@samdroid-apps
Copy link
Contributor Author

FYI, I previously tested this on a 0.106.whatever XO and it worked fine. Hopefully this could be merged.

@samdroid-apps
Copy link
Contributor Author

Would be great to get this in 0.110. What's the maintainership story with activities? Who reviews code now that they are all in the sugar-labs org?

@devAbnull
Copy link
Contributor

@samdroid-apps I tried using this patch but the activity fails to start.
Shell shows this error:

Traceback (most recent call last):
File "/home/broot/sugar-build/build/out/install/bin/sugar-activity", line 169, in
main()
File "/home/broot/sugar-build/build/out/install/bin/sugar-activity", line 164, in main
instance = create_activity_instance(activity_constructor, activity_handle)
File "/home/broot/sugar-build/build/out/install/bin/sugar-activity", line 42, in create_activity_instance
activity = constructor(handle)
File "/home/broot/sugar-build/build/out/install/share/sugar/activities/Write.activity/AbiWordActivity.py", line 138, in init
self._image_id = image.connect('clicked', self._image_cb)
AttributeError: 'AbiWordActivity' object has no attribute '_image_cb'

@samdroid-apps
Copy link
Contributor Author

That's odd. Does it relate to https://github.com/sugarlabs/write-activity/pull/3/files ?

@samdroid-apps
Copy link
Contributor Author

No, it doesn't related to that. The def _image_cb is 100% there: https://github.com/sugarlabs/write-activity/blob/master/AbiWordActivity.py#L477

@devAbnull
Copy link
Contributor

The activity is running fine. But still cannot share it among other users :(

@samdroid-apps
Copy link
Contributor Author

Did you apply the patch for both users? Any logs? What connection manager, salut (no jabber server) or gabble (a jabber server)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants