Allow the user to stop processing flags after seeing N args #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-thurston
force-pushed
the
feat/stop-on-nth-arg
branch
3 times, most recently
from
0c5bcbe to
9d3591b
Compare
We have switched from v2 to v3 mainly because we want to support parsing flags after the arguments. There are many other benefits, but this one drove the work. We do have some commands where the old v2 behaviour is desirable, specifically, when we pass arguments through. For example our ssh command: tool ssh MACHINE-NAME ls -la To support this on a per-command basis, added an option to the Command struct called StopOnNthArg. It terminates flag parsing like '--'.
adrian-thurston
force-pushed
the
feat/stop-on-nth-arg
branch
from
9d3591b to
4905fd6
Compare
adrian-thurston
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
We have switched from v2 to v3 mainly because we want to support flags after the arguments. There are many other benefits, but this one drove the work.
We do have some commands though where the old v2 behaviour is desirable, specifically, when we pass arguments through. For example our ssh command:
It is possible to require the user to use the special argument
--, however we would prefer to not disrupt existing usage where the old bahaviour is relied on.To support this per-command, added an option to the Command struct called
StopOnNthArg. It terminates flag parsing after seeing N positional arguments.Which issue(s) this PR fixes:
There is no issue for this that I am aware of.
Special notes for your reviewer:
Using a pointer to
intmight be considered odd. Maybe there is a project convention to follow?Testing
Test cases for the feature have been added.
Release Notes