Define epoch matching #209
Merged
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I considered doing this in the way that the issue suggested, but when I got down to it, that would require the definition of a new method to get epoch start and end times. This does it based on epoch indices. In short, this iterates all impressions in the store, gets the epoch index that corresponds to the timestamp, and skips any that are not equal to the epoch we're looking at. I've tweaked the short circuit on lookback to also use epoch index. It checks whether the epoch index for now - lookback is less than the current epoch. In practice, this would be horribly inefficient. You would definitely not want to implement things this way. The upside is that this is fairly straightforward to specify and understand. Closes #207.
csharrison
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered doing this in the way that the issue suggested, but when I got down to it, that would require the definition of a new method to get epoch start and end times. This does it based on epoch indices.
In short, this iterates all impressions in the store, gets the epoch index that corresponds to the timestamp, and skips any that are not equal to the epoch we're looking at.
I've tweaked the short circuit on lookback to also use epoch index. It checks whether the epoch index for now - lookback is less than the current epoch.
In practice, this would be horribly inefficient. You would definitely not want to implement things this way. The upside is that this is fairly straightforward to specify and understand.
Closes #207.
Preview | Diff