Skip to content

$badfilter rules with collisions break the filtering engime #7867

Open
@Metrokoto

Description

@Metrokoto

Prerequisites

Platform (OS and CPU architecture)

Linux, AMD64 (aka x86_64)

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

0.107.52

Action

I am using ShadowWhisperer's TLD list which was recently formatted to work with AdGuard Home, however, I am also using whitelist based filtering for all Microsoft domains, meaning github.io is filtered as well.

As I wished for my filtering to exclude the top 100 TLDs, I created rules like

||*.io^badfilter

-to prevent the rule blocking .io and the other top TLDs from executing.

The issue I found is that when you have a domain blocked two or more ways, doing something like

||*.io^badfilter
||github.io^badfilter

-does not act as it should, and github.io and all subdomains remain blocked.

Image

I could whitelist github.io explicitly, but due to it being a UGC domain, I would much rather the bug be fixed to avoid such broad whitelists.

Expected result

The expected result is that both rules should be deactivated, as this is how it works in, eg; uBlock Origin.

Actual result

All other .io domains minus github.io are affected by the badfilter rule for .io

Image

Additional information and/or screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions