-
-
Notifications
You must be signed in to change notification settings - Fork 81
Add support for Neon database in db-setup and update dependencies #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Neon database in db-setup and update dependencies #339
Conversation
🦋 Changeset detectedLatest commit: 2444ad6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis change adds support for the Neon database in the CLI's database setup process. It updates dependency management, modifies the setup logic for the "drizzle" ORM to handle Neon-specific dependencies, and adapts the Drizzle Postgres template to conditionally initialize connections using the Neon client when appropriate. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant Template
participant NPM
User->>CLI: Initiate database setup (Drizzle/Postgres)
CLI->>CLI: Check dbSetup value
alt dbSetup is "neon"
CLI->>NPM: Install drizzle-orm, @neondatabase/serverless, drizzle-kit
CLI->>Template: Generate index.ts.hbs with Neon client logic
else dbSetup is default
CLI->>NPM: Install drizzle-orm, pg, drizzle-kit, @types/pg
CLI->>Template: Generate index.ts.hbs with pg client logic
end
CLI->>User: Setup complete
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
ad314a2
to
1361351
Compare
i have already updated the deps @bibblebabl sync it |
ef6a5fa
to
721a16a
Compare
721a16a
to
e063a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/large-lizards-write.md (1)
5-5
: Consider elaborating the summary for clearer release notesA one-line description is OK, but adding one or two extra sentences detailing what “Add support for Neon database in db-setup” entails (e.g., new dependencies, conditional logic, template changes) will make the generated changelog more informative for consumers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.changeset/large-lizards-write.md
(1 hunks)
🔇 Additional comments (1)
.changeset/large-lizards-write.md (1)
1-3
: Validate that the correct package(s) are targeted in the changeset headerOnly
"create-better-t-stack"
is listed. If the Neon-support work touched other publishable packages (e.g. the CLI, shared utilities, or any internal libs), they must be enumerated here as well; otherwise those packages will not receive a version bump when the changeset is applied.
Please confirm that no additional packages require inclusion.
Thanks @bibblebabl I have removed the database healthcheck I'll add it a bit differently later |
Summary by CodeRabbit
New Features
Chores