Skip to content

Another prototype for async HttpClient APIs #45836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

alzimmermsft
Copy link
Member

Description

Related to #45816

This is another prototype for an async HttpClient send method. This design has the async API declared in HttpClient as sendAsync with a default implementation.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Contributor

github-actions bot commented Jul 1, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

io.clientcore:core

Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good - a few minor comments and some cleanup.

* used for re-authentication.
*
* <p>
* The default implementation doesn't handle challenges. You can override and your implementation as needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced we want to default to a bad implementation? If we can do anything useful, it's probably better to do nothing at all?

Suggested change
* The default implementation doesn't handle challenges. You can override and your implementation as needed.
* The default implementation doesn't handle challenges. You can override in your implementation as needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this question to @g2vinay as I was simply making the async code path based on the sync logic.

@alzimmermsft alzimmermsft marked this pull request as ready for review July 2, 2025 19:23
@alzimmermsft alzimmermsft requested review from samvaity, vcolin7 and a team as code owners July 2, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants