Skip to content

Fix constellation line fade distance #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AstroChara
Copy link
Contributor

As per Issue #2176. Removed the random scaling factor applied to “dist” value, which is confusing and unintuitive. Now constellation lines should show up at interstellar distances, as preferred by many users. If fading at smaller distance is preferred then it would make sense to change the constants themselves rather than this.

Removed the random scaling factor which is confusing and unintuitive. Now constellation lines should show up at interstellar distances, as preferred by many users.
Copy link

@375gnu
Copy link
Collaborator

375gnu commented Jun 21, 2025

If for some reason you need this, then:

  1. add a new boolean flag in Render
  2. add a new interface option to toggle distance fading

@AstroChara
Copy link
Contributor Author

Eventually it may be a good idea to add a way to manually input custom fade distances for the three elements of constellations in the program. For now, simply turning the constellation lines off should be sufficient as it does more or less the same thing fading asterism lines outside the Solar System does.

@pedro-fixingstuff
Copy link
Contributor

I think exposing the fade distances as settings in celestia.cfg would be good. It makes sense to have the fade itself be a toggleable setting (with the default being enabled!).

@AstroChara
Copy link
Contributor Author

I think exposing the fade distances as settings in celestia.cfg would be good. It makes sense to have the fade itself be a toggleable setting (with the default being enabled!).

I support this idea. It allows full customizability of the fading while not being too difficult to implement (hopefully) nor taking too much space in the setting (you need three sliders for three elements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants