-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[Junie]: fix: display help output for --help argument #13446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Junie]: fix: display help output for --help argument #13446
Conversation
The JabRef CLI was modified to display help output when the `--help` argument is provided while JabRef is running, instead of passing the argument to the running instance. This change resolves the previous issue where users did not see the help output. Other command-line arguments remain unaffected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jetbrains-junie
can't we use picocli here?
mixinStandardHelpOptions = true
…7-493f-8670-6157111bc3d4
This needs more thought put into. We already do an exception for debug. Now this is going to be an abonimation. The ArgumentProcessor (PicoCli) needs to be properly used. I think handling of multiple instances has to be split and things being send to the running instance only if it is not help or sthg. Do not do a bad hotfix here. |
…7-493f-8670-6157111bc3d4
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
…7-493f-8670-6157111bc3d4
@trag-bot didn't find any issues in the code! ✅✨ |
📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview
It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We’d love your feedback — join our Discord to share bugs, ideas: here.
--help
should output help #13243--help
should output help📊 Junie Summary
The JabRef CLI was modified to display help output when the
--help
argument is provided while JabRef is running, instead of passing the argument to the running instance. This change resolves the previous issue where users did not see the help output. Other command-line arguments remain unaffected.