Skip to content

[Junie]: fix: display help output for --help argument #13446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jetbrains-junie[bot]
Copy link
Contributor

📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview

It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We’d love your feedback — join our Discord to share bugs, ideas: here.

📊 Junie Summary

The JabRef CLI was modified to display help output when the --help argument is provided while JabRef is running, instead of passing the argument to the running instance. This change resolves the previous issue where users did not see the help output. Other command-line arguments remain unaffected.

 The JabRef CLI was modified to display help output when the `--help` argument is provided while JabRef is running, instead of passing the argument to the running instance. This change resolves the previous issue where users did not see the help output. Other command-line arguments remain unaffected.
@jetbrains-junie jetbrains-junie bot added the junie label Jul 3, 2025
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jetbrains-junie
can't we use picocli here?

mixinStandardHelpOptions = true

https://picocli.info/#_mixin_standard_help_options

@calixtus
Copy link
Member

calixtus commented Jul 4, 2025

This needs more thought put into. We already do an exception for debug. Now this is going to be an abonimation. The ArgumentProcessor (PicoCli) needs to be properly used. I think handling of multiple instances has to be split and things being send to the running instance only if it is not help or sthg. Do not do a bad hotfix here.
Adding dev-call label here.

Copy link

trag-bot bot commented Jul 7, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: devcall labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
junie status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants