Skip to content

Modify the spp_change_request module to support SP-MIS and Farmer Registry CR type modules #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gonzalesedwin1123
Copy link
Member

Why is this change needed?

A new spp_change_request_base module is created in PR: #777 to support any change request implementations. This PR will modify the existing spp_change_request to support only the SP-MIS and Farmer Registry change request implementations.

How was the change implemented?

The spp_change_request module was modified and will depend on the new parent module spp_change_request_base. SP-MIS and Farmer Registry specific change request requirements will be maintained in this module.

New unit tests

Unit tests executed by the author

How to test manually

Related links

Enhancement to Change Request module

@gonzalesedwin1123 gonzalesedwin1123 self-assigned this Apr 15, 2025
@gonzalesedwin1123 gonzalesedwin1123 linked an issue Apr 15, 2025 that may be closed by this pull request
Copy link

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 70.66667% with 66 lines in your changes missing coverage. Please review.

Project coverage is 76.47%. Comparing base (7eb47f9) to head (2d4a8c3).
Report is 49 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_change_request/models/change_request.py 43.47% 24 Missing and 2 partials ⚠️
spp_api/controllers/pinguin.py 0.00% 15 Missing ⚠️
spp_change_request/models/mixins/source_mixin.py 25.00% 9 Missing ⚠️
spp_starter/wizards/spp_starter.py 77.77% 2 Missing and 6 partials ⚠️
...armer_registry_demo/models/generate_farmer_data.py 20.00% 4 Missing ⚠️
spp_starter/tests/test_spp_starter.py 85.71% 3 Missing ⚠️
spp_mis_demo/models/generate_group.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #791      +/-   ##
==========================================
+ Coverage   75.68%   76.47%   +0.78%     
==========================================
  Files         764      757       -7     
  Lines       20218    19984     -234     
  Branches     2501     2444      -57     
==========================================
- Hits        15303    15283      -20     
+ Misses       4381     4170     -211     
+ Partials      534      531       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 force-pushed the modify_change_request_to_support_new_CR_base_module branch from 8c696fa to 12c7b70 Compare July 2, 2025 04:48
Copy link

sonarqubecloud bot commented Jul 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
37.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement to Change Request module
5 participants