Skip to content

Add equal to Bytes.sol and update pragma to 0.8.24 in String dependencies #5726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ernestognw
Copy link
Member

In #5725, we're moving the equal function from Strings to Bytes.sol for convenience, that'd require updating the pragma of Strings's dependencies to 0.8.24 since mcopy is needed.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Jun 9, 2025

🦋 Changeset detected

Latest commit: da6a179

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ernestognw ernestognw force-pushed the chore/solidity-8-24 branch from c89daf2 to ef6cfba Compare June 9, 2025 01:35
@Amxx
Copy link
Collaborator

Amxx commented Jun 9, 2025

Where is mcopy used ? the pragma checking scripts says Strings is fine in 0.8.20.

@ernestognw
Copy link
Member Author

Where is mcopy used ? the pragma checking scripts says Strings is fine in 0.8.20.

The description is pretty clear about where's used: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5725/files#diff-e402541b45f70ec8d3de9b9f87542d9eb52920601ac011a340e723c5b4b9d659R136

I generally split the PRs because then they are too big to review, but then done individually lose context...

@Amxx
Copy link
Collaborator

Amxx commented Jun 9, 2025

So this PR changes all pragma, and increass the requirements on many file, to prepare for a change in the code that is NOT in this PR, and that we are not even sure of doing in the near future ?

I would say no to that kind of change. I'd even consider not adding Strings.equal considering all the breaking pragma and the limited upside.

@ernestognw ernestognw changed the title Update pragma to 0.8.24 in String dependencies Add equal to Bytes.sol and update pragma to 0.8.24 in String dependencies Jun 9, 2025
@ernestognw
Copy link
Member Author

Include the equal function from #5725 as discussed

@ernestognw ernestognw requested a review from Amxx June 9, 2025 16:33
@Amxx Amxx requested a review from a team as a code owner June 18, 2025 19:43
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to update that part when the Changelog from 5.4 makes it into master. Other than that, I think its all good.

Would still wait for 5.4 merge back in master. I prefer having conflicts to resolve on this PR, then on the 5.4 merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants