Skip to content

add strategies for user2new_group #10765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

cyy536
Copy link
Contributor

@cyy536 cyy536 commented Jun 24, 2025

PR types

Others

PR changes

Others

Description

配合Paddle通信库的升级,具体来说是NCCL初始化的升级,需要从PaddleNLP获取NCCL配置

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 37.14286% with 22 lines in your changes missing coverage. Please review.

Project coverage is 46.82%. Comparing base (f068df3) to head (1e26483).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/training_args.py 33.33% 22 Missing ⚠️

❌ Your patch check has failed because the patch coverage (37.14%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (46.82%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10765      +/-   ##
===========================================
- Coverage    46.82%   46.82%   -0.01%     
===========================================
  Files          801      801              
  Lines       133423   133454      +31     
===========================================
+ Hits         62480    62488       +8     
- Misses       70943    70966      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"help": "nccl config of pipeline paralle",
},
)
tensor_parallel_nccl_config: Optional[Dict[str, Dict[str, Union[int, str]]]] = field(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的多个 XX_nccl_config, 是否能合并成同一个配置,在配置内再区别不同的并行策略,以提高可扩展和维护性

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PP 应该是有多个 Config 需要配置?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants