Skip to content

Commit 4727e0e

Browse files
authored
Merge pull request github#3375 from github/koesie10/react-processed-by-auto-model
Add `processedByAutoModelMethods` state to React view
2 parents 3b30f22 + bca4910 commit 4727e0e

File tree

9 files changed

+20
-1
lines changed

9 files changed

+20
-1
lines changed

extensions/ql-vscode/src/view/model-editor/LibraryRow.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ export type LibraryRowProps = {
7474
modifiedSignatures: Set<string>;
7575
selectedSignatures: Set<string>;
7676
inProgressMethods: Set<string>;
77+
processedByAutoModelMethods: Set<string>;
7778
viewState: ModelEditorViewState;
7879
hideModeledMethods: boolean;
7980
revealedMethodSignature: string | null;
@@ -98,6 +99,7 @@ export const LibraryRow = ({
9899
modifiedSignatures,
99100
selectedSignatures,
100101
inProgressMethods,
102+
processedByAutoModelMethods,
101103
viewState,
102104
hideModeledMethods,
103105
revealedMethodSignature,
@@ -237,6 +239,7 @@ export const LibraryRow = ({
237239
modifiedSignatures={modifiedSignatures}
238240
selectedSignatures={selectedSignatures}
239241
inProgressMethods={inProgressMethods}
242+
processedByAutoModelMethods={processedByAutoModelMethods}
240243
viewState={viewState}
241244
hideModeledMethods={hideModeledMethods}
242245
revealedMethodSignature={revealedMethodSignature}

extensions/ql-vscode/src/view/model-editor/MethodRow.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ export type MethodRowProps = {
7575
methodIsUnsaved: boolean;
7676
methodIsSelected: boolean;
7777
modelingInProgress: boolean;
78+
processedByAutoModel: boolean;
7879
viewState: ModelEditorViewState;
7980
revealedMethodSignature: string | null;
8081
inputAccessPathSuggestions?: AccessPathOption[];

extensions/ql-vscode/src/view/model-editor/ModelEditor.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ export function ModelEditor({
103103
const [inProgressMethods, setInProgressMethods] = useState<Set<string>>(
104104
new Set(),
105105
);
106+
const [processedByAutoModelMethods, setProcessedByAutoModelMethods] =
107+
useState<Set<string>>(new Set());
106108

107109
const [hideModeledMethods, setHideModeledMethods] = useState(
108110
initialHideModeledMethods,
@@ -149,7 +151,7 @@ export function ModelEditor({
149151
break;
150152
}
151153
case "setProcessedByAutoModelMethods": {
152-
// TODO: set state
154+
setProcessedByAutoModelMethods(new Set(msg.methods));
153155
break;
154156
}
155157
case "revealMethod":
@@ -392,6 +394,7 @@ export function ModelEditor({
392394
modifiedSignatures={modifiedSignatures}
393395
selectedSignatures={selectedSignatures}
394396
inProgressMethods={inProgressMethods}
397+
processedByAutoModelMethods={processedByAutoModelMethods}
395398
viewState={viewState}
396399
hideModeledMethods={hideModeledMethods}
397400
revealedMethodSignature={revealedMethodSignature}

extensions/ql-vscode/src/view/model-editor/ModeledMethodDataGrid.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export type ModeledMethodDataGridProps = {
1919
modifiedSignatures: Set<string>;
2020
selectedSignatures: Set<string>;
2121
inProgressMethods: Set<string>;
22+
processedByAutoModelMethods: Set<string>;
2223
viewState: ModelEditorViewState;
2324
hideModeledMethods: boolean;
2425
revealedMethodSignature: string | null;
@@ -33,6 +34,7 @@ export const ModeledMethodDataGrid = ({
3334
modifiedSignatures,
3435
selectedSignatures,
3536
inProgressMethods,
37+
processedByAutoModelMethods,
3638
viewState,
3739
hideModeledMethods,
3840
revealedMethodSignature,
@@ -93,6 +95,9 @@ export const ModeledMethodDataGrid = ({
9395
methodIsUnsaved={modifiedSignatures.has(method.signature)}
9496
methodIsSelected={selectedSignatures.has(method.signature)}
9597
modelingInProgress={inProgressMethods.has(method.signature)}
98+
processedByAutoModel={processedByAutoModelMethods.has(
99+
method.signature,
100+
)}
96101
viewState={viewState}
97102
revealedMethodSignature={revealedMethodSignature}
98103
inputAccessPathSuggestions={inputAccessPathSuggestions}

extensions/ql-vscode/src/view/model-editor/ModeledMethodsList.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export type ModeledMethodsListProps = {
1616
modifiedSignatures: Set<string>;
1717
selectedSignatures: Set<string>;
1818
inProgressMethods: Set<string>;
19+
processedByAutoModelMethods: Set<string>;
1920
revealedMethodSignature: string | null;
2021
accessPathSuggestions?: AccessPathSuggestionOptions;
2122
viewState: ModelEditorViewState;
@@ -42,6 +43,7 @@ export const ModeledMethodsList = ({
4243
modifiedSignatures,
4344
selectedSignatures,
4445
inProgressMethods,
46+
processedByAutoModelMethods,
4547
viewState,
4648
hideModeledMethods,
4749
revealedMethodSignature,
@@ -91,6 +93,7 @@ export const ModeledMethodsList = ({
9193
modifiedSignatures={modifiedSignatures}
9294
selectedSignatures={selectedSignatures}
9395
inProgressMethods={inProgressMethods}
96+
processedByAutoModelMethods={processedByAutoModelMethods}
9497
viewState={viewState}
9598
hideModeledMethods={hideModeledMethods}
9699
revealedMethodSignature={revealedMethodSignature}

extensions/ql-vscode/src/view/model-editor/__tests__/LibraryRow.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ describe(LibraryRow.name, () => {
3636
modifiedSignatures={new Set([method.signature])}
3737
selectedSignatures={new Set()}
3838
inProgressMethods={new Set()}
39+
processedByAutoModelMethods={new Set()}
3940
viewState={viewState}
4041
hideModeledMethods={false}
4142
revealedMethodSignature={null}

extensions/ql-vscode/src/view/model-editor/__tests__/MethodRow.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ describe(MethodRow.name, () => {
4343
methodIsUnsaved={false}
4444
methodIsSelected={false}
4545
modelingInProgress={false}
46+
processedByAutoModel={false}
4647
revealedMethodSignature={null}
4748
viewState={viewState}
4849
onChange={onChange}

extensions/ql-vscode/src/view/model-editor/__tests__/ModeledMethodDataGrid.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ describe(ModeledMethodDataGrid.name, () => {
5858
modifiedSignatures={new Set([method1.signature])}
5959
selectedSignatures={new Set()}
6060
inProgressMethods={new Set()}
61+
processedByAutoModelMethods={new Set()}
6162
viewState={viewState}
6263
hideModeledMethods={false}
6364
revealedMethodSignature={null}

extensions/ql-vscode/src/view/model-editor/__tests__/ModeledMethodsList.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ describe(ModeledMethodsList.name, () => {
5959
modifiedSignatures={new Set([method1.signature])}
6060
selectedSignatures={new Set()}
6161
inProgressMethods={new Set()}
62+
processedByAutoModelMethods={new Set()}
6263
viewState={viewState}
6364
hideModeledMethods={false}
6465
revealedMethodSignature={null}

0 commit comments

Comments
 (0)