Skip to content

Commit 38849f7

Browse files
asgerfaeisenberg
andauthored
Apply suggestions from code review
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
1 parent bb1da9c commit 38849f7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

extensions/ql-vscode/src/common/jsonl-reader.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const doubleLineBreakRegexp = /\n\r?\n/;
1313
export async function readJsonlFile<T>(
1414
path: string,
1515
handler: (value: T) => Promise<void>,
16-
logger?: { log: (message: string) => void },
16+
logger?: BaseLogger,
1717
): Promise<void> {
1818
// Stream the data as large evaluator logs won't fit in memory.
1919
// Also avoid using 'readline' as it is slower than our manual line splitting.
@@ -48,7 +48,7 @@ export async function readJsonlFile<T>(
4848
return;
4949
}
5050
}
51-
void logger?.log(`Finishing parsing ${path}`);
51+
void logger?.log(`Finished parsing ${path}`);
5252
resolve();
5353
});
5454
stream.on("error", reject);

0 commit comments

Comments
 (0)