Merge pull request github#3833 from asgerf/asgerf/graph-viewer-scrollpos

asgerf · web-flow · commit dba671864962 · 2024-11-22T10:19:27.000+01:00
Avoid resetting scroll position after clicking a node in the graph viewer
diff --git a/extensions/ql-vscode/src/view/results/Graph.tsx b/extensions/ql-vscode/src/view/results/Graph.tsx
@@ -48,7 +48,10 @@ export function Graph({ graphData, databaseUri }: GraphProps) {
             d.attributes["xlink:href"] = "#";
             d.attributes["href"] = "#";
             loc.uri = `file://${loc.uri}`;
-            select(this).on("click", () => jumpToLocation(loc, databaseUri));
+            select(this).on("click", (event: Event) => {
+              jumpToLocation(loc, databaseUri);
+              event.preventDefault(); // Avoid resetting scroll position
+            });
           }
         }
         if ("fill" in d.attributes) {

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,10 @@ export function Graph({ graphData, databaseUri }: GraphProps) {`
`48`	`48`	`d.attributes["xlink:href"] = "#";`
`49`	`49`	`d.attributes["href"] = "#";`
`50`	`50`	loc.uri = `file://${loc.uri}`;
`51`		`- select(this).on("click", () => jumpToLocation(loc, databaseUri));`
	`51`	`+ select(this).on("click", (event: Event) => {`
	`52`	`+ jumpToLocation(loc, databaseUri);`
	`53`	`+ event.preventDefault(); // Avoid resetting scroll position`
	`54`	`+ });`
`52`	`55`	`}`
`53`	`56`	`}`
`54`	`57`	`if ("fill" in d.attributes) {`