Skip to content

Commit eee5939

Browse files
committed
Fix typo in 'evaluatorLogPaths'
1 parent 4e32a10 commit eee5939

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

extensions/ql-vscode/src/log-insights/log-scanner-service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,12 @@ export class LogScannerService extends DisposableObject {
9494
public async scanEvalLog(query: QueryHistoryInfo | undefined): Promise<void> {
9595
this.diagnosticCollection.clear();
9696

97-
if (query?.t !== "local" || query.evalutorLogPaths === undefined) {
97+
if (query?.t !== "local" || query.evaluatorLogPaths === undefined) {
9898
return;
9999
}
100100

101101
const { summarySymbols, jsonSummary, humanReadableSummary } =
102-
query.evalutorLogPaths;
102+
query.evaluatorLogPaths;
103103

104104
if (jsonSummary === undefined || humanReadableSummary === undefined) {
105105
return;

extensions/ql-vscode/src/query-history/query-history-manager.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -781,7 +781,7 @@ export class QueryHistoryManager extends DisposableObject {
781781

782782
private async warnNoEvalLogSummary(item: LocalQueryInfo) {
783783
const evalLogLocation =
784-
item.evalutorLogPaths?.log ?? item.initialInfo.outputDir?.evalLogPath;
784+
item.evaluatorLogPaths?.log ?? item.initialInfo.outputDir?.evalLogPath;
785785

786786
// Summary log file doesn't exist.
787787
if (evalLogLocation && (await pathExists(evalLogLocation))) {
@@ -801,7 +801,7 @@ export class QueryHistoryManager extends DisposableObject {
801801
}
802802

803803
const evalLogLocation =
804-
item.evalutorLogPaths?.log ?? item.initialInfo.outputDir?.evalLogPath;
804+
item.evaluatorLogPaths?.log ?? item.initialInfo.outputDir?.evalLogPath;
805805

806806
if (evalLogLocation && (await pathExists(evalLogLocation))) {
807807
await tryOpenExternalFile(this.app.commands, evalLogLocation);
@@ -816,14 +816,14 @@ export class QueryHistoryManager extends DisposableObject {
816816
}
817817

818818
// If the summary file location wasn't saved, display error
819-
if (!item.evalutorLogPaths?.humanReadableSummary) {
819+
if (!item.evaluatorLogPaths?.humanReadableSummary) {
820820
await this.warnNoEvalLogSummary(item);
821821
return;
822822
}
823823

824824
await tryOpenExternalFile(
825825
this.app.commands,
826-
item.evalutorLogPaths.humanReadableSummary,
826+
item.evaluatorLogPaths.humanReadableSummary,
827827
);
828828
}
829829

@@ -833,15 +833,15 @@ export class QueryHistoryManager extends DisposableObject {
833833
}
834834

835835
// If the JSON summary file location wasn't saved, display error
836-
if (item.evalutorLogPaths?.jsonSummary === undefined) {
836+
if (item.evaluatorLogPaths?.jsonSummary === undefined) {
837837
await this.warnNoEvalLogSummary(item);
838838
return;
839839
}
840840

841841
// TODO(angelapwen): Stream the file in.
842842
try {
843843
const evalLogData: EvalLogData[] = await parseViewerData(
844-
item.evalutorLogPaths.jsonSummary,
844+
item.evaluatorLogPaths.jsonSummary,
845845
);
846846
const evalLogTreeBuilder = new EvalLogTreeBuilder(
847847
item.getQueryName(),
@@ -850,7 +850,7 @@ export class QueryHistoryManager extends DisposableObject {
850850
this.evalLogViewer.updateRoots(await evalLogTreeBuilder.getRoots());
851851
} catch {
852852
throw new Error(
853-
`Could not read evaluator log summary JSON file to generate viewer data at ${item.evalutorLogPaths.jsonSummary}.`,
853+
`Could not read evaluator log summary JSON file to generate viewer data at ${item.evaluatorLogPaths.jsonSummary}.`,
854854
);
855855
}
856856
}

extensions/ql-vscode/src/query-history/store/query-history-local-query-domain-mapper.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ export function mapLocalQueryInfoToDto(
2525
return {
2626
initialInfo: mapInitialQueryInfoToDto(query.initialInfo),
2727
t: "local",
28-
evalLogLocation: query.evalutorLogPaths?.log,
29-
evalLogSummaryLocation: query.evalutorLogPaths?.humanReadableSummary,
30-
jsonEvalLogSummaryLocation: query.evalutorLogPaths?.jsonSummary,
31-
evalLogSummarySymbolsLocation: query.evalutorLogPaths?.summarySymbols,
28+
evalLogLocation: query.evaluatorLogPaths?.log,
29+
evalLogSummaryLocation: query.evaluatorLogPaths?.humanReadableSummary,
30+
jsonEvalLogSummaryLocation: query.evaluatorLogPaths?.jsonSummary,
31+
evalLogSummarySymbolsLocation: query.evaluatorLogPaths?.summarySymbols,
3232
failureReason: query.failureReason,
3333
completedQuery:
3434
query.completedQuery && mapCompletedQueryToDto(query.completedQuery),

extensions/ql-vscode/src/query-results.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ export class LocalQueryInfo {
200200
private cancellationSource?: CancellationTokenSource, // used to cancel in progress queries
201201
public failureReason?: string,
202202
public completedQuery?: CompletedQueryInfo,
203-
public evalutorLogPaths?: EvaluatorLogPaths,
203+
public evaluatorLogPaths?: EvaluatorLogPaths,
204204
) {
205205
/**/
206206
}
@@ -226,7 +226,7 @@ export class LocalQueryInfo {
226226

227227
/** Sets the paths to the various structured evaluator logs. */
228228
public setEvaluatorLogPaths(logPaths: EvaluatorLogPaths): void {
229-
this.evalutorLogPaths = logPaths;
229+
this.evaluatorLogPaths = logPaths;
230230
}
231231

232232
/**

0 commit comments

Comments
 (0)