fetch tags when fetch-depth > 0. fix #1781 #2039
Open
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!refSpec.some(x => x === refHelper.tagsRefSpec) && !options.fetchTags) { | ||
| args.push('--no-tags') | ||
| if (options.fetchTags) { | ||
| args.push('--tags') |
There was a problem hiding this comment.
this won't work.
the bug in git cause the --tags get ignored when we pass any refspec.
19:38:51.501221 git.c:476 trace: built-in: git fetch --prune --no-recurse-submodules --depth=1 --tags origin +dafa907d050b7aca612cb1fc3262cbe1157a41d4:refs/remotes/origin/main
From https://github.com/TingluoHuang/repo-3208316
+ 2e53bff...dafa907 dafa907d050b7aca612cb1fc3262cbe1157a41d4 -> origin/main (forced update)
vs older git version
19:45:56.613886 git.c:479 trace: built-in: git fetch --prune --no-recurse-submodules --depth=1 --tags origin +dafa907d050b7aca612cb1fc3262cbe1157a41d4:refs/remotes/origin/main
From https://github.com/TingluoHuang/repo-3208316
+ 5b6b8cc...dafa907 dafa907d0[50](https://github.com/TingluoHuang/repo-3208316/actions/runs/13315815917/job/37189415774#step:4:51)b7aca612cb1fc3262cbe1157a41d4 -> origin/main (forced update)
* [new tag] v13315501148 -> v13315501148
* [new tag] v13315557600 -> v13315557600
* [new tag] v13315584914 -> v13315584914
* [new tag] v13315601791 -> v13315601791
* [new tag] v133156378[52](https://github.com/TingluoHuang/repo-3208316/actions/runs/13315815917/job/37189415774#step:4:53) -> v13315637852
* [new tag] v13315718561 -> v13315718561
* [new tag] v13315732428 -> v13315732428
* [new tag] v13315782509 -> v13315782509
monicadiaz68071978
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1781