Skip to content

fix: set text alignment for keyboard component #8480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

LucidityDesign
Copy link

Closes #8343

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@LucidityDesign LucidityDesign reopened this Jul 2, 2025
@LucidityDesign LucidityDesign changed the title fix: set text alignment in keyboard component fix: set text alignment for keyboard component Jul 2, 2025
@LucidityDesign LucidityDesign reopened this Jul 2, 2025
@LucidityDesign LucidityDesign reopened this Jul 2, 2025
@LucidityDesign LucidityDesign reopened this Jul 2, 2025
@LucidityDesign
Copy link
Author

LucidityDesign commented Jul 2, 2025

After singing the CLA, reopening doesn't solve the "CLA signed" check. Do I have to create a new PR?

@snowystinger
Copy link
Member

I'd double check that you used the e-mail address matching this github account. It's pretty common to use a different one unintentionally

@LucidityDesign
Copy link
Author

I double checked both email addresses I used in the original commit and in another PR
(#8485) but to no avail.

Might be not worth the hassle for on line of code. So please don't hesitate to close this PR and create one yourself

@snowystinger
Copy link
Member

apologies, I'm not sure what's going on with it, I can't even see the failed request for the CLA for some reason
I've opened a PR here #8486, thanks for putting this one together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard components within MenuItems do not keep same alignment across MenuSections
2 participants