Skip to content

Don't automatically derive BundleFromComponents with Bundle #19560

Open
@alice-i-cecile

Description

@alice-i-cecile

Instead of making BundleFromComponents opt-out, though, would it make sense to have it be opt-in and require #[derive(Bundle, BundleFromComponents)]? That better matches the general convention that a derive only implements a single trait. And if you do need to call take, the trait bound should help guide you to derive the second trait.

Originally posted by @chescock in #19249 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ECSEntities, components, systems, and eventsC-UsabilityA targeted quality-of-life change that makes Bevy easier to useD-MacrosCode that generates Rust codeD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesM-Needs-Migration-GuideA breaking change to Bevy's public API that needs to be noted in a migration guideS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed upon

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions