Use deps to infer more accurate linting #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias
requested changes
Jun 10, 2025
| @@ -22,7 +22,8 @@ | |||
| (pattern [re] (.pattern re)) | |||
| (groupnames [_] []) | |||
| re/RegexFragment | |||
| (static? [_ _] true)) | |||
| (static? [_ _] true) | |||
| (recursimplify [_ _] (throw (ex-info "Not implemented" {})))) | |||
|
Merged, thanks @frenchy64! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the docs, adding
--dependencieswill copy more accurate information to the clj-kondo cache.This found a couple of minor issues like #904, but makes linting much more useful in the future.
You may need to manually clear
.clj-kondo/.cacheonce.I added an explicit dep on hiccup because we use it. Hiccup and kerodon need clj-kondo configs, which I temporarily added to
.clj-kondo/imports. They will be overwritten if we bump these deps and they provide their own configs.I didn't commit
.clj-kondo/importsto keep the PR small, though it is recommended. In practice it won't make a difference, but add!.clj-kondo/importsto.gitignoreto commit the imports.