Skip to content

Update filters.md #35627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

Update filters.md #35627

merged 3 commits into from
Jun 18, 2025

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Jun 16, 2025

Fixes #35598
Remove an incorrect diagram.


Internal previews

📄 File 🔗 Preview link
aspnetcore/mvc/controllers/filters.md Filters in ASP.NET Core

Remove a problematic image.
@tdykstra tdykstra marked this pull request as ready for review June 16, 2025 23:45
@tdykstra tdykstra requested a review from Copilot June 16, 2025 23:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the filters documentation to fix issue #35598 by removing an incorrect diagram and expanding on the details of exception filters.

  • Removes the outdated filter pipeline diagram.
  • Updates the exception filters section to include additional execution details.

@tdykstra tdykstra requested a review from wadepickett June 16, 2025 23:46
@@ -65,18 +65,18 @@ Each filter type is executed at a different stage in the filter pipeline:
* Are **not** supported in Razor Pages.
* Can be invoked on both actions and route handler-based endpoints.

* [Exception filters](#exception-filters) apply global policies to unhandled exceptions that occur before the response body has been written to.
* [Exception filters](#exception-filters):
* Apply global policies to unhandled exceptions that occur before the response body has been written to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Apply global policies to unhandled exceptions that occur before the response body has been written to.
* Apply global policies to unhandled exceptions that occur before the response body has been written to.

Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a very minor misalignment on a list, I removed the extra space.

tdykstra and others added 2 commits June 17, 2025 12:36
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
@tdykstra tdykstra enabled auto-merge (squash) June 17, 2025 20:33
auto-merge was automatically disabled June 17, 2025 20:38

Pull Request is not mergeable

@tdykstra tdykstra enabled auto-merge (squash) June 17, 2025 20:38
auto-merge was automatically disabled June 17, 2025 20:42

Pull Request is not mergeable

@tdykstra tdykstra enabled auto-merge (squash) June 17, 2025 20:44
auto-merge was automatically disabled June 17, 2025 20:48

Pull Request is not mergeable

@tdykstra tdykstra closed this Jun 18, 2025
@tdykstra tdykstra reopened this Jun 18, 2025
@tdykstra tdykstra merged commit 8fdc5ad into main Jun 18, 2025
3 of 4 checks passed
@tdykstra tdykstra deleted the tdykstra-patch-1 branch June 18, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The order of Exception filter is incorrect among the list of filter types
2 participants