Syncing test.toml and updating the test code for largest-series-product

[jagdish-15]

Pull Request

This PR syncs tests.toml with the problem-specifications repository and verifies the presence of new tests in the test file.

[github-actions]

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

---

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[jagdish-15]

@SleeplessByte @Cool-Katt

Do you think it's worth changing the error comments, considering many existing solutions on the track might fail if we go ahead with this?

Lemme know so I can proceed with the proof solution!

[SleeplessByte]

@SleeplessByte @Cool-Katt

Do you think it's worth changing the error comments, considering many existing solutions on the track might fail if we go ahead with this?

Lemme know so I can proceed with the proof solution!

What does "changing the error comments" mean?

[jagdish-15]

By error comment I was referring to the message inside new Error(). This sync only changes that message for two tests, so I’m wondering if it’s worth updating them, especially since all the old solutions fail now due to these new messages differing from the original ones.

[SleeplessByte]

Yes, being in sync with spec removes bike shedding. Check out this message: #2647 (comment)

If we merge with that, no solutions will be retested.

[Cool-Katt]

I feel that tagging this with [no important files changed] may be okay, to not rerun all the current solutions.

Other option would be to simply test it the function throws anything, which I don't think is okay, or to test if it throws an instance of some error class (that would have to be written because it currently doesn't exist)

[jagdish-15]

Tagging it makes more sense to me for now!