Skip to content

Fix ci erorrs #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Fix ci erorrs #2655

merged 2 commits into from
Jun 6, 2025

Conversation

Cool-Katt
Copy link
Contributor

@Cool-Katt Cool-Katt commented Jun 6, 2025

this should probably be tagged, as the bot says...

Cool-Katt added 2 commits June 6, 2025 16:20
Remove implicit coercion (attempt 1)
the description of a `test` cannot start with the word 'test'
Copy link
Contributor

github-actions bot commented Jun 6, 2025

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@Cool-Katt Cool-Katt requested a review from SleeplessByte June 6, 2025 13:23
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting how this was not caught

@SleeplessByte SleeplessByte merged commit a73813c into main Jun 6, 2025
10 checks passed
@SleeplessByte SleeplessByte deleted the fix-ci-erorrs branch June 6, 2025 13:46
@Cool-Katt
Copy link
Contributor Author

Ye, probably because I'm a dumbass, lol

@SleeplessByte SleeplessByte added x:action/fix Fix an issue x:module/practice-exercise Work on Practice Exercises x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) labels Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/fix Fix an issue x:module/practice-exercise Work on Practice Exercises x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants