Protein Translation: Rewrite per discussion #2570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacG
approved these changes
Jun 7, 2025
BNAndras
approved these changes
Jun 7, 2025
There was a problem hiding this comment.
Lovely! My only nit is to use one sentence per line. See https://exercism.org/docs/building/markdown/markdown#h-one-sentence-per-line
tasxatzial
reviewed
Jun 7, 2025
kotp
approved these changes
Jun 7, 2025
|
As far as I know, a strand would be the entire nucleotide chain. A sequence would refer to the parts being transcribed at any given moment. A RNA string likely is just a RNA sequence misidentified then. |
|
Those RNA terms might be good to discuss in a follow up. |
SleeplessByte
approved these changes
Jun 8, 2025
There was a problem hiding this comment.
Please apply the suggestions by Erik, and I agree with the confusion raised by @tasxatzial, but also with @IsaacG that that should be tackled in a follow-up so this can be merged and propagated :)
kotp
changed the title
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
|
Done. Thanks everyone! Review required to unblock the merge. |
IsaacG
approved these changes
Jun 14, 2025
ErikSchierboom
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...at http://forum.exercism.org/t/tweak-language-and-formatting-in-protein-translation-description-md/17005/72