[Rework]: Add swift 5.8 and new features #43
Conversation
| "name" : "testAdd", | ||
| "output" : "yabba", | ||
| "status" : "fail", | ||
| "task_id" : 1, |
There was a problem hiding this comment.
It looks like all exercises now have a task_id, which is not how we envisioned it. Couldn't you have a contention where the class needs to start with Task or Task1 or something, to distinguish between concept exercise tests and practice exercise tests?
There was a problem hiding this comment.
I have thought that I may compare the first and the last test and if they have the same task id I remove them? Since even if there is a concept with only 1 task it still aint that useful.
Otherwise checking class name is also an option
There was a problem hiding this comment.
I have thought that I may compare the first and the last test and if they have the same task id I remove them? Since even if there is a concept with only 1 task it still aint that useful.
Well, it does change how the UI is rendered, so I'd like it to be there even then.
There was a problem hiding this comment.
Well I can make it check class name
|
I'm having a slightly hard time reading the diff, but are you running the tests only once (you mentioned running it more than once in a chat)? |
|
I am running from run.sh and there you can see it is only called once. It even runs in parallel, so may be faster? I am not sure. |
| "status" : "fail" | ||
| "message" : "/solution/Tests/MultipleWithExceptionTests/MultipleWithExceptionTests.swift:19: error: MultipleWithExceptionTests.testThrow : XCTAssertEqual threw error \"testError(\"Oh noes! Div by zeroes!!!\")\" -", | ||
| "name" : "testThrow", | ||
| "status" : "error", |
There was a problem hiding this comment.
This should be a fail, as error is for when the tests couldn't even run (which they did in this case).
There was a problem hiding this comment.
I see, I guess that at least in swift, I guess a single test case can't be labeled as an error.
There was a problem hiding this comment.
Yeah. Same goes for virtually all compiled languages
No description provided.