Skip to content

Remove allTests constant in practice exercises #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Jun 19, 2023

Apple appears to have changed things so that you no longer have to explicitly tell the test runner which tests exist.

This removes the explicitly defined allTests constant from the practice exercises.

Note that I'm not actually sure this will work—I'm making the PR so that we can see if CI passes. Edit: seems like it's working...

Apple appears to have changed things so that you no longer have
to explicitly tell the test runner which tests exist.

This removes the explicitly defined allTests constant from
the practice exercises.
@kytrinyx
Copy link
Member Author

Let me know what you all think. If this looks good I can try doing the same thing for the concept exercises.

Copy link
Member

@meatball133 meatball133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, and it should work.

One thing which concerns me is that this pr would likely cause the website to rerun tests for all exercises on the track. This includes I think around 180.000 iteratons, but I think that should still be fine.

@kytrinyx
Copy link
Member Author

Yes, it would definitely cause everything to be re-run. Let's wait for @ErikSchierboom to weigh in on that. We may want to wait to merge to make sure there isn't anything else going on at the same time.

@ErikSchierboom
Copy link
Member

I think it looks good, and it should work.

Is there a corresponding test runner PR that verifies this? As in: a PR that updates the golden tests?

@ErikSchierboom
Copy link
Member

Yes, it would definitely cause everything to be re-run.

We'll be working on something to bypass this (not having to run everything).

@meatball133
Copy link
Member

Is there a corresponding test runner PR that verifies this? As in: a PR that updates the golden tests?

I could start writing one, but I have done testing which points at that there shouldn't be any problems, both on the test runner and my local machine.

@meatball133
Copy link
Member

@ErikSchierboom
Copy link
Member

That's great. I would propose to wait merging this until we have the "ignore test runs" feature deployed

@ErikSchierboom ErikSchierboom merged commit 2f60d6f into main Jul 14, 2023
@ErikSchierboom ErikSchierboom deleted the all-tests-practice branch July 14, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants