Skip to content

Implement grayscale DMG palette specs #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jun 28, 2025

Fixes #1594

This also fixes a bug where if a subsequent -c flag overrides a previous one, but the previous one specified an external palette file, then the previous overridden one would still try to parse the external file.

@Rangi42 Rangi42 added this to the 0.9.3 milestone Jun 28, 2025
@Rangi42 Rangi42 requested a review from ISSOtm June 28, 2025 18:40
@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbgfx This affects RGBGFX labels Jun 28, 2025
@Rangi42
Copy link
Contributor Author

Rangi42 commented Jun 28, 2025

The main advantage of this feature is that a Makefile can specify -c dmg=e4 and then not have to worry about two common problems: if the PNG has an indexed PLTE, and if the PNG doesn't use the exact right shades of gray (which would be a problem if you specified -c '#fff,#aaa,#555,#000').

ISSOtm
ISSOtm previously requested changes Jun 29, 2025
@Rangi42 Rangi42 requested a review from ISSOtm June 29, 2025 21:43
@Rangi42 Rangi42 merged commit 7054d81 into gbdev:master Jun 30, 2025
23 checks passed
@Rangi42 Rangi42 deleted the dmg-pal-spec branch June 30, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Typically new features; lesser priority than bugs rgbgfx This affects RGBGFX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Specify -c/--colors as a DMG grayscale ordering
3 participants