IMPACT: improve the management of the available workflow approaches #10698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheles
reviewed
Jul 4, 2025
| 'use_finite_fault_model_from_usgs', | ||
| 'provide_rup', | ||
| 'provide_rup_params'), | ||
| 'approach': valid.Choice(*list(IMPACT_APPROACHES)), |
There was a problem hiding this comment.
You don't need list() here
micheles
reviewed
Jul 4, 2025
| @@ -1366,7 +1366,7 @@ def get_shakemap_versions(usgs_id, user=User(), monitor=performance.Monitor()): | |||
| return shakemap_versions, usgs_preferred_version, err | |||
|
|
|||
|
|
|||
| def _convert_rupture_file(rupture_file, usgs_id, user): | |||
| def _convert_rupture_file(dic, rupture_file, usgs_id, user): | |||
| rup = None | |||
There was a problem hiding this comment.
I would like a better name than dic, making clear which parameters it contains (I guess it is the inputdic containing the parameters in the WebUI form).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The available workflow approaches are stored in a dictionary with their short name and description, that is also used to get the available items for validation. In the level 2 form, keys and values are read from that dictionary.
I am also making sure that the notification that is sent to the user via email at job completion contains the information about the chosen approach (written in the human-readable string).