Only allow -switch-to-rbr when inspecting replica #999

New issue

Jump to bottom

Open

shlomi-noach wants to merge 82 commits into github:master from openark:switch-to-rbr-only-on-replica

Contributor

shlomi-noach commented Jun 29, 2021

Resubmission of openark#23 from downstream

Fixes #991

gh-ost will fail with error when -switch-to-rbr is provided and when running directly on primary (--allow-on-master).

Low risk

No changes to migration logic, just added command line validation

shlomi-noach added 30 commits

July 28, 2020 12:10


          Merge pull request #2 from openark/workflow-upload-artifact

9b2a04d

Actions/Workflow: upload artifact


          Merge pull request #5 from openark/parse-alter-statement

9ccde4f

Support a complete ALTER TABLE statement in --alter


          merged conflict

b59a8ed


          Merge pull request #8 from openark/ajm188-handle_driver_timeout_error

6012e80

handle driver timeout error


          v1.1.0

ae22d84


          Merge remote-tracking branch 'upstream/master' into updates-from-upst…

ca0ca5a

…ream-2020-10


          Merge pull request #11 from openark/updates-from-upstream-2020-10

e9f9af2

 Updates from upstream 2020 10


          WIP: copying AUTO_INCREMENT value to ghost table

294d43b

Initial commit: towards setting up a test suite

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          greping for 'expect_table_structure' content

26f7602


          Adding simple test for 'expect_table_structure' scenario

75009db


          adding tests for AUTO_INCREMENT value after row deletes. Should initi…

eeab264

…ally fail


          clear event beforehand

2d0281f


          parsing AUTO_INCREMENT from alter query, reading AUTO_INCREMENT from …

af20211

…original table, applying AUTO_INCREMENT value onto ghost table if applicable and user has not specified AUTO_INCREMENT in alter statement


          support GetUint64

31069ae

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          minor update to test

3d4dfaa

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          adding test for user defined AUTO_INCREMENT statement

63219ab


          Merge branch 'master' into copy-auto-increment

525a80d


          Merge pull request #12 from openark/copy-auto-increment

ff82140

Copying AUTO_INCREMENT value to ghost table


          Generated column as part of UNIQUE (or PRIMARY) KEY

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          skip analysis of generated column data type in unique key

b7b3bfb

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          Merge pull request #13 from openark/unique-key-generated-column

253658d

Generated column as part of UNIQUE (or PRIMARY) KEY


          Merge pull request #14 from ccoffey/cathal/safer_cut_over

4a36e24

Cut-over should wait for heartbeat lag to be low enough to succeed


          All MySQL DBs limited to max 3 concurrent/idle connections

710c9dd

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          Merge branch 'master' into limit-mysql-connetions

dea8d54


          Merge pull request #15 from openark/limit-mysql-connetions

2b5cf78

All MySQL DBs limited to max 3 concurrent/idle connections


          hooks: reporting GH_OST_ETA_SECONDS. ETA stored as part of migration …

54000ab

…context

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          GH_OST_ETA_NANOSECONDS

51719a2

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          N/A denoted by negative value

76b9c16

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          ETAUnknown constant

b688c58

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          Merge pull request #17 from openark/hooks-eta-seconds

33516f4

hooks: reporting GH_OST_ETA_SECONDS. ETA as part of migration context

shlomi-noach and others added 14 commits

October 26, 2021 12:06


          support go1.7

37813ec

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          added test suite

5e0f152

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          relax sql_mode for test

0ea04fb

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          Merge pull request #32 from openark/existing-date-with-zero

ded0f91

Support tables with existing zero dates


          add trigger struct, resolve comments in pr

c91d9d7


          go fmt

0a271d0


          Merge pull request #1 from xtrimf/support_for_triggers

e049a6c

Support for triggers


          go fmt

0f97a08


          reuse GetGhostTriggerName

1e4bbcb


          Merge pull request #2 from xtrimf/support_for_triggers

d30bc0d

Support for triggers


          change trigger suffix logic


          Merge pull request #3 from xtrimf/support_for_triggers

96cd286

change trigger suffix logic


          gofmt

765a1df

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>


          Merge pull request #30 from xtrimf/support_for_triggers_no_rollback

277dfa3

Support for triggers no rollback

timvaillancourt added this to the v1.1.5 milestone

timvaillancourt self-requested a review

June 2, 2022 22:40

timvaillancourt previously approved these changes

View reviewed changes

Collaborator

timvaillancourt left a comment •

edited

Loading

👋/:pray: @shlomi-noach, sorry for the delay!

LGTM once this is rebased 👍. Currently can't merge

dm-2 previously approved these changes

View reviewed changes

dm-2 modified the milestones: v1.1.5, v1.1.6

timvaillancourt added the low-risk label


          merged master, resolved conflict

e7d9342

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Contributor Author

shlomi-noach commented Aug 21, 2022 •

edited

Loading

The golangci-lint test fails, with what seems like useless output?

2022-08-21T05:54:12.7308332Z ##[group]run golangci-lint
2022-08-21T05:54:12.7312245Z Running [/home/runner/golangci-lint-1.46.2-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
2022-08-21T05:54:26.8253755Z ##[error]unnecessary trailing newline (whitespace)
2022-08-21T05:54:26.8266486Z ##[error]unnecessary trailing newline (whitespace)
2022-08-21T05:54:26.8267648Z ##[error]unnecessary trailing newline (whitespace)
2022-08-21T05:54:26.8268825Z ##[error]S1011: should replace loop with `result.columns = append(result.columns, columns1.Columns()...)` (gosimple)
2022-08-21T05:54:26.8270059Z ##[error]S1011: should replace loop with `result.columns = append(result.columns, columns2.Columns()...)` (gosimple)

I'm actually unable to find where exactly the linter sees the issue?

Collaborator

timvaillancourt commented Aug 21, 2022 •

edited

Loading

I'm actually unable to find where exactly the linter sees the issue?

@shlomi-noach thanks! Yikes, that output isn't so useful 🤔

This check-annotations page has much more useful output and clicking on each nit jumps to the code (TIL 🚀): https://github.com/github/gh-ost/actions/runs/2897390310. It looks like it's mad about some extra whitespace and 2 x loops that could be simplified to append(something, other...) 👍

timvaillancourt dismissed stale reviews from dm-2 and themself via

e7d9342

October 21, 2022 15:47

timvaillancourt modified the milestones: v1.1.6, v1.1.7

meiji163 modified the milestones: v1.1.7, v1.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels