-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add token source flag, gh cli auth #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- go.mod: Language not supported
89d4dae
to
91fcecd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
cmd/github-mcp-server/main.go:227
- [nitpick] The variable name 'token_source' does not follow Go naming conventions. Renaming it to 'tokenSource' would improve readability and adhere to idiomatic Go style.
token_source := viper.GetString("token-source")
Wondering if this should be leveraging |
@pauldthomson Definitely agree, there should be some tooling provided by There is a broader discussion to be had about how fine-grained authorization could be handled by the server, given many users want to grant varying levels of access to different resources (e.g. read-write access to current repo, but read-only access to other repos). It could go a long way to addressing the perennial claims of github-mcp-server being "exploited" by poisoned prompts to extract private data. |
This PR adds support for using the GitHub CLI's token. Users pass
--token-source gh
to enable it (defaulting to "env" token source). It also includes a couple of changes that should make it straightforward to publish a GitHub CLI extension (#215) that uses "gh" as the default source.