feat: implement get_repository_discussions tool with GraphQL support #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rociomontes
reviewed
Apr 14, 2025
| Locked bool `json:"locked"` | ||
| UpvoteCount int `json:"upvoteCount"` | ||
| CommentCount int `json:"commentCount"` | ||
| Comments []Comment `json:"comments,omitempty"` |
There was a problem hiding this comment.
Really glad we would be able to also have access to the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature: Fetch GitHub Discussions
pkg/github/discussions.go: Added a new tool to fetch discussions from a specific GitHub repository using the GraphQL API. This includes defining structures forCommentandDiscussion, and implementing theGetRepositoryDiscussionsfunction.Server Setup Updates
cmd/github-mcp-server/main.go: Updated the server setup to create and use a GraphQL client alongside the REST API client. This includes changes to therunStdioServerfunction to handle OAuth2 token creation and GraphQL client initialization. [1] [2] [3]Dependency Modifications
go.mod: Added dependencies forgithubv4andoauth2to support the new GraphQL functionality. [1] [2]Additional Changes
pkg/github/server.go: Modified the server creation function to accept a GraphQL client and added the newGetRepositoryDiscussionstool to the server. [1] [2]script/test_get_repository_discussions.sh: Added a test script to verify the functionality of theget_repository_discussionstool.Open questions
Debating if the client should be an interface rather than passing it in another function to the
server.