Skip to content

Adds support for CNAMEs to CNAMEs #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Adds support for CNAMEs to CNAMEs #112

merged 1 commit into from
Feb 6, 2019

Conversation

dmalan
Copy link
Contributor

@dmalan dmalan commented Nov 12, 2018

Fixes #111.

@parkr
Copy link
Contributor

parkr commented Nov 16, 2018

I dig this! Please introduce a test for this.

@dmalan
Copy link
Contributor Author

dmalan commented Dec 23, 2018

Sure, @parkr, would it be best for GitHub's team to create a new record in github.com (or elsewhere) that's a CNAME for, e.g., mattr-.github.com (which is, itself, a CNAME for github.github.io) so that GitHub fully controls the test (rather than use a third-party domain like our own)? Looks like @benbalter added a test using that particular record?

@parkr
Copy link
Contributor

parkr commented Jan 4, 2019

@dmalan I'd love to use stubs here instead of relying on public DNS. Is that something you'd be willing to give a try? If not, I can try my hand at a test.

@parkr
Copy link
Contributor

parkr commented Feb 6, 2019

I have a test written and passing on a local branch but can't push changes to this PR. I'll merge this and push up a separate PR for that.

@parkr parkr merged commit fa6bd0f into github:master Feb 6, 2019
@dmalan
Copy link
Contributor Author

dmalan commented Feb 6, 2019

Ah, thank you, @parkr! Apologies for the belated reply, afraid this fell off my radar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants