Silence warnings triggered by Ruby 2.7 #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2020 13:30
Ruby 2.7 adds some new warnings. In particular, previously if a method
was defined with keyword arguments, you could create a hash and pass it to
the method, and Ruby wouldn't complain.
Now, however, Ruby wants you to explicitly pass **the_hash instead of just
the_hash where keyword arguments are expected.
The version of public_suffix that this codebase was relying on emitted the
following warnings:
lib/ruby/gems/2.7.0/gems/public_suffix-3.1.1/lib/public_suffix/list.rb:51:
warning: Using the last argument as keyword parameters is deprecated;
maybe ** should be added to the call
lib/public_suffix/list.rb:69:
warning: The called method `parse' is defined here
v4.0.3 fixes these warnings.
I had to set the version specifier in the gemspec to >= 3.0 in order to
manage to upgrade github/github, otherwise bundle gets its dependencies
in a tizzy.
Once github/github is updated, we could update this to be ~> 4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.7 adds some new warnings. In particular, previously if a method was
defined with keyword arguments, you could create a hash and pass it to the
method, and Ruby wouldn't complain.
Now, however, Ruby wants you to explicitly pass **the_hash instead of just
the_hash where keyword arguments are expected.
The version of public_suffix that this codebase was relying on emitted the
following warnings:
v4.0.3 fixes these warnings.
I had to set the version specifier in the gemspec to >= 3.0 in order to manage
to upgrade github/github, otherwise bundler gets its dependencies in a tizzy.
Once github/github is updated, we could update this to be ~> 4.0