Follow redirects in GitHubPages::HealthCheck#served_by_pages? #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many apex domains like http://getbootstrap.com/ use A records (rather than ALIAS/ANAME records):
GitHub Pages will sometimes respond with a
302 Found
for these domains:Previously the GitHubPages::HealthCheck#served_by_pages? check could fail because it would make a request which would respond with a
302 Found
and theServer: GitHub.com
header wouldn't be included in the response.This fixes the issue by retrying the request, which should then result in a
200 OK
response which includes theServer: GitHub.com
header./cc @benbalter