Add AAAA Support #136
Merged
Add AAAA Support #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jriggins
force-pushed
the
aaaa-support/jriggins
branch
3 times, most recently
from
c871cb3 to
ced3fba
Compare
parkr
reviewed
Sep 6, 2021
jriggins
force-pushed
the
aaaa-support/jriggins
branch
from
e4e1168 to
b8d52f0
Compare
jcudit
reviewed
Sep 7, 2021
There was a problem hiding this comment.
👍🏾 on most of this but will defer an approval after a second read as this is a good chunk to review.
Specifically, the tests look good and the updates to update-cdn-ips are 👌🏾 too. I'm still weighing the pros and cons around merging A and AAAA checks into single functions as it makes for an easier implementation but increases risk around misuse of the API.
|
ℹ️ Going to make some updates. |
jriggins
force-pushed
the
aaaa-support/jriggins
branch
from
f9146ea to
fe48335
Compare
|
Ready for another review. 🚀 |
TooManyBees
reviewed
Sep 9, 2021
| `git add --verbose #{file}` | ||
| end | ||
|
|
||
| def parse_cdn_response(source, ips) | ||
| send("parse_#{source}", ips) |
There was a problem hiding this comment.
🍜 not a blocker, but I think it's more readable here to
case source
when "fastly"
# ...
when "cloudflare"
# ...
else
raise "oh no #{source}"
end
jcudit
previously approved these changes
Sep 9, 2021
jriggins
force-pushed
the
aaaa-support/jriggins
branch
from
d2d981c to
2786ce0
Compare
tcbyrd
approved these changes
Sep 10, 2021
| 2606:50c0:8000::153 | ||
| 2606:50c0:8001::153 | ||
| 2606:50c0:8002::153 | ||
| 2606:50c0:8003::153 |
There was a problem hiding this comment.
👍 , but just for confirmation:
curl https://api.github.com/meta | jq .pages | grep ::
"2606:50c0:8000::153/128",
"2606:50c0:8001::153/128",
"2606:50c0:8002::153/128",
"2606:50c0:8003::153/128"There was a problem hiding this comment.
Thanks. Yeah I bet I had a bad block cut on the CIDR and left the 8 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.