Skip to content

Handle NXDOMAIN correctly. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2015
Merged

Handle NXDOMAIN correctly. #15

merged 4 commits into from
Apr 15, 2015

Conversation

spraints
Copy link
Member

In our prod environment, resolv.conf includes search github.com. This leads to pages-health-check returning OK for domains like this-does-not-exist.io, because:

$ host this-does-not-exist.io
this-does-not-exist.io.github.com is an alias for github.map.fastly.net.
github.map.fastly.net has address 199.27.75.133
  • failing test
  • make the test fail in travis
  • fix

cc @jdennes @github/pages

@spraints
Copy link
Member Author

Sweet. Travis fails now, too:

Failures:
  1) GitHubPages::HealthCheck does not resolve domains that do not exist
     Failure/Error: expect(check.dns).to be_empty
       expected `[this-domain-does-not-exist-and-should-not-ever-exist.io.github.com.   29   IN   CNAME   github.map.fastly.net., github.map.fastly.net.  16      IN      A       199.27.75.133].empty?` to return true, got false
     # ./spec/github_pages_health_check_spec.rb:191:in `block (2 levels) in <top (required)>'

@jdennes
Copy link
Member

jdennes commented Apr 15, 2015

Nice!

spraints added a commit that referenced this pull request Apr 15, 2015
@spraints spraints merged commit b18a124 into github:master Apr 15, 2015
@spraints spraints deleted the prod-cname branch April 15, 2015 18:22
@benbalter
Copy link
Contributor

Nice catch. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants