Use correct keyword argument when creating Dnsruby::Resolver #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+46
to
+54
| :nameserver => authoritative_nameservers | ||
| )) | ||
| when :public | ||
| Dnsruby::Resolver.new(DEFAULT_RESOLVER_OPTIONS.merge( | ||
| :nameservers => PUBLIC_NAMESERVERS | ||
| :nameserver => PUBLIC_NAMESERVERS | ||
| )) | ||
| when Array | ||
| Dnsruby::Resolver.new(DEFAULT_RESOLVER_OPTIONS.merge( | ||
| :nameservers => nameservers | ||
| :nameserver => nameservers |
There was a problem hiding this comment.
Corrects the keyword argument to :nameserver based on the official documentation for Dnsruby::Resolver.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
I know, dude, I was there when I wrote it. 👍🏼
| )) | ||
| when :public | ||
| Dnsruby::Resolver.new(DEFAULT_RESOLVER_OPTIONS.merge( | ||
| :nameservers => PUBLIC_NAMESERVERS | ||
| :nameserver => PUBLIC_NAMESERVERS |
There was a problem hiding this comment.
Ensures the correct keyword argument is used for public resolvers by changing from :nameservers to :nameserver.
Copilot uses AI. Check for mistakes.
| )) | ||
| when Array | ||
| Dnsruby::Resolver.new(DEFAULT_RESOLVER_OPTIONS.merge( | ||
| :nameservers => nameservers | ||
| :nameserver => nameservers |
There was a problem hiding this comment.
Updates the array-based resolver configuration to use the :nameserver keyword, aligning with the expected API.
Suggested change
| :nameserver => nameservers | |
| nameserver: nameservers |
Copilot uses AI. Check for mistakes.
YiMysty
approved these changes
Apr 10, 2025
yoannchaudet
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a typo. See https://www.rubydoc.info/gems/dnsruby/Dnsruby%2FResolver:initialize