Check if domain is proxied #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
proxied?
method to check if a domain is served by pages, but is proxied by a third-party service. If so, the Health Check shouldn't raise CNAME/A record errors.The logic is as follows. A domain is proxied if:
(I also cleaned up some new test-related warnings that recently appeared by explicitly defining an expected error and explicitly vendoring test dependencies)
/cc @github/pages, @konklone