Properly detect if domain is served by pages for non-200 response codes #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbalter
added a commit
that referenced
this pull request
Aug 12, 2015
Properly detect if domain is served by pages for non-200 response codes
|
Test added via 6def034. |
parkr
added a commit
that referenced
this pull request
Jan 12, 2016
* master: (28 commits) travis: use Ruby 2.1.7 Upgrade to Ruby 2.1.7-github per https://pages.github.com/versions/ 💎 bump Memoize served_by_pages? == false Memoize dns = nil typo in comment 💎 bump actually check that a domains dns resolves 💎 bump add invalid_dns.rb to gemspec add timeout to DNS check add script/check 💎 bump require net-dns 0.8 add check for #26 💎 bump properly detect if domain is served by pages for non-200 response codes 💎 bump remove some diff noise use addressable::uri to support domains with underscores ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were using
response.success?which returnsfalsefor non-200 response codes including 30x and 40x status.Even if a GitHub Pages site isn't set up (e.g.,
/404s), theserved_by_pages?` check should still be able to determine if it's the Pages server, so long as we're able to connect and we don't time out.Note, when mocking response,
response.return_codeappears to benil.Cribbed from https://github.com/typhoeus/typhoeus/blob/35a4d5b6f7c818a0c11b0c1e10a20b30c754e169/lib/typhoeus/response/status.rb#L48-L50.