Add timeout to DNS check #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a shared 10 second timeout between HTTP and DNS checks, and better guards against failing loudly if the DNS check fails for whatever reason.
If the DNS check fails, any check that relies on DNS will return nil, rather than returning a false positive/negative. Check! will return an InvalidDNS error.
Last, memoize served_by_pages? to save on subsequent calls (which may also timeout).
/cc @nuclearsandwich