Port Cloudflare Updates #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fi | ||
|
|
||
| #set ruby version, see https://github.com/github/pages-jekyll/pull/17 | ||
| export PATH=/usr/share/rbenv/shims:$PATH BUNDLE_GEMFILE=$(pwd)/Gemfile |
There was a problem hiding this comment.
This seems weird to be in bootstrap. If this is just for CI, maybe move the boostrap in cibuild so it's after the env updates?
There was a problem hiding this comment.
Agreed, but without that, it bootstraps into global ruby, which is 1.8.x. Pulled from the Pages bootstrap.
|
🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to port @spraints's cloudflare updates from https://github.com/github/pages/pull/370.
Once merged, hope to be able to PR to pages, and can then use in https://github.com/github/shell/pull/1273 and stafftools.