Check if domain is CNAME to pages.github.com or directly to Fastly #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should these be errors? If I do a |
I thought of this as simply extending the definition of what an Invalid CNAME entails, and as such, you get a |
|
Cool! Was checking it on my 📱. Looking on a slightly larger screen, all seems marvelous! |
benbalter
added a commit
that referenced
this pull request
Feb 16, 2016
Check if domain is CNAME to pages.github.com or directly to Fastly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request expands the
InvalidCNAMEcheck to look for two additional conditions:page.github.com, not[username].github.iogithub.map.fastly.netdirectly, not to[username].github.ioIn both cases, the misconfiguration makes it harder for us to prevent abuse at the DNS level.
To accomplish this,
Domain#cnamenow returns a Domain object, rather than the CNAME string, allowing us to more easily run checks on the target domain (where the CNAME resolves to).Fixes #40.