Better human-readable error messages #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def message_with_url | ||
| msg = message.gsub(/\s+/, " ").squeeze(" ").strip | ||
| msg << "." unless msg =~ /\.$/ | ||
| [msg, more_info].join(" ") |
There was a problem hiding this comment.
This is really confusing. Can you write a comment about what it should produce, i.e. provide an example?
|
Looks pretty good to me. |
|
@parkr good calls both. Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to move the more descriptive human-readable error messages that GitHub Pages uses into the open source Ruby gem, where they can be shared between implementations. Specifically, errors, as exposed via
HealthCheck#reasonhave an expanded#messagemethod, and also expose#message_with_urlwhich would provide a URL to the help docs.The code's definitely a bit rough and could use some 👀.