Domain#cname? should return false if the value of the CNAME is bad #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbalter
reviewed
Oct 13, 2016
| @@ -199,7 +203,8 @@ def a_record? | |||
| # Is this domain's first response a CNAME record? | |||
| def cname_record? | |||
| return unless dns? | |||
| dns.first.class == Net::DNS::RR::CNAME | |||
| dns.first.class == Net::DNS::RR::CNAME && | |||
| Domain.valid_domain?(dns.first.cname.to_s) | |||
There was a problem hiding this comment.
I believe this can be cname.valid_domain? We already instantiate a domain for the cname via https://github.com/github/pages-health-check/blob/master/lib/github-pages-health-check/domain.rb#L210.
Perhaps it'd make more sense to have the CNAME method confirm the class, and then cname? can just look for the existence?
There was a problem hiding this comment.
OK, what do you think of my update in 392d28c, @benbalter?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you do a
digand you get:...then you should not get a healthy CNAME.
Fixes #60.
/cc @github/pages @antn