Skip to content

Custom #to_json methods must accept the state parameter #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

parkr
Copy link
Contributor

@parkr parkr commented Apr 24, 2018

This allows a Checkable to be a member of another item that has a to_json method, like Hash.

Example:

require 'json'
require 'github-pages-health-check'
entry = { check: GitHubPages::HealthCheck::Domain.new("www.parkermoore.de") }
entry.to_json

That currently fails with an ArgumentError, but this PR makes it work.

@parkr parkr merged commit 919b89e into master Apr 24, 2018
@parkr parkr deleted the accept-json-state branch April 24, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant